mirror of
https://codeberg.org/KeybadeBlox/JSRF-Decompilation.git
synced 2026-02-20 10:17:03 +03:00
Add stylistic consistency to contribution guide
This commit is contained in:
parent
fe94d467df
commit
70cc4ca688
1 changed files with 6 additions and 1 deletions
|
|
@ -243,7 +243,12 @@ correctly (exception-handling code might be appended onto another function, for
|
||||||
example). Because `symboltable.tsv` should only be populated with symbols that
|
example). Because `symboltable.tsv` should only be populated with symbols that
|
||||||
have been manually defined as per the previous section, this means that you
|
have been manually defined as per the previous section, this means that you
|
||||||
need to define variable names and labels in Ghidra for everything therein (and
|
need to define variable names and labels in Ghidra for everything therein (and
|
||||||
ideally everything referenced externally, as well).
|
ideally everything referenced externally, as well). Do try to maintain basic
|
||||||
|
consistency with the rest of the codebase: functions and methods begin with
|
||||||
|
lowercase letters, for instance, while class/struct/enum names begin with
|
||||||
|
capital letters, and special methods like constructors and destructors should
|
||||||
|
have the names they would have in real C++ code (i.e. `Class::Class` and
|
||||||
|
`Class::~Class`, respectively).
|
||||||
|
|
||||||
Once an object is ready for extracting, its `Delink?` column should be set to
|
Once an object is ready for extracting, its `Delink?` column should be set to
|
||||||
`true` and the `objdiff.json` file in the `decompile/` directory should be
|
`true` and the `objdiff.json` file in the `decompile/` directory should be
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue